Conversation
Author
|
This has been sitting around on my PC for a long time, and I just fixed some conflicts, then uploaded it. Might as well not let it go to waste. |
ghost
closed this by deleting the head repository
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Focus
Essentially, this removes the need to check the OS since it'll be built for the target OS, maybe the tiniest minuscule performance boost. Thoughts?
Unrelated
Also this does make a huge change to the .csproj markup layout, so yeah, that's great.
All Changes
csprojfile.scpslExecutableis now set at the definition.OS_WIN32&OS_LINUXprecompile definitions, then replaced theOperatingSystem.Is[Platform]()calls with precompiler definitions. (In theLocalAdmin.csfile.)